Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX support width appDir enabled #47523

Open
1 task done
Doodidan opened this issue Mar 25, 2023 · 24 comments
Open
1 task done

MDX support width appDir enabled #47523

Doodidan opened this issue Mar 25, 2023 · 24 comments
Labels
area: app App directory (appDir: true) bug Issue was opened via the bug report template. Markdown (MDX) Related to Markdown with Next.js.

Comments

@Doodidan
Copy link

Doodidan commented Mar 25, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Home
    Binaries:
      Node: 18.14.0
      npm: N/A
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.2.5-canary.16
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

App directory (appDir: true), MDX (@next/mdx)

Link to the code that reproduces this issue

https://github.com/GoshaEgorian/next-mdx-bug-reproduction

To Reproduce

  1. npm run dev
  2. localhost:3000

Describe the Bug

MDX cannot be rendered with new app dir 'cause of context

Expected Behavior

MDX renders normally

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

@Doodidan Doodidan added the bug Issue was opened via the bug report template. label Mar 25, 2023
@github-actions github-actions bot added area: app App directory (appDir: true) Markdown (MDX) Related to Markdown with Next.js. labels Mar 25, 2023
@KonstantinSimeonov
Copy link

KonstantinSimeonov commented Apr 13, 2023

I've ran into this as well. I tried splitting up the mdx code as components, adding a "use client" directive in them and then rendering them in a page, but this didn't work.

// stuff.mdx

"use client"

# hello
// page.tsx
import Hello from "./stuff.mdx"

export default function DoesntWork() {
  return <Hello />
}

@traversng
Copy link

@Doodidan I believe you need to import your mdx file in your page.tsx. Your example code shows just a page.md file with markdown.

  1. Turn that page into content.mdx
  2. Create a page.tsx file
  3. Import that content into page.tsx like
import Content from './content.mdx'

export default function ShouldWork() {
  return <Content />
}

This should work in @latest

@MatthewCaseres
Copy link

I am having the same issue and have a reproduction with an mdx file - https://github.com/MatthewCaseres/mdx-repro. I am going to close my duplicate issue and just follow this issue.

@traversng do you have an example I can clone from where it is working properly with latest version?

@tannerabread
Copy link

Hi @MatthewCaseres for your case, if you move mdx-components.tsx to the root of your project it fixes the issue

@MatthewCaseres
Copy link

@tannerabread Thank you! The repo is updated to help as a working example for others who are having issues.

@Doodidan
Copy link
Author

@Doodidan I believe you need to import your mdx file in your page.tsx. Your example code shows just a page.md file with markdown.

1. Turn that page into `content.mdx`

2. Create a `page.tsx` file

3. Import that content into `page.tsx` like
import Content from './content.mdx'

export default function ShouldWork() {
  return <Content />
}

This should work in @latest

Yes, I found working eample with this. But plain .mdx files without page.tsx work fine with old architecture. So, I find it as a bug.

@kossidts
Copy link

kossidts commented Jun 9, 2023

Thanks for the solution @Doodidan. It only works when I set the "use client"; directive at the top of page.tsx. Without that I am still getting the createContext-error.
To me it's not clear why the directive is necessary since I am using plain md and it's not mentioned once in the official documentation.

@mnieber
Copy link

mnieber commented Jun 9, 2023

@kossidts In my case, it was fixed when adding the mdx-components.tsx file as mentioned in the docs, and adding mdxRs: true in the config. It does work (for me) without use client.

@damien
Copy link

damien commented Jun 19, 2023

Hey folks! Chiming in that I've encountered this error as a somebody new to NextJS and getting up to speed with MDX. The instructions as is in the live docs invariably result in the same message reported above:

error createContext only works in Client Components. Add the "use client" directive at the top of the file to use it. Read more: https://nextjs.org/docs/messages/context-in-server-component

So my question: What's the intended path for usage of MDX going forward? What should I expect?

I'm fine using the implementation proposed (import MDX content into a TSX component and render from there with the appropriate client/server pragma)--but it'd be nice to know if the documentation is out of date or this is an ephemeral implementation issue within NextJS 13.x.

Cheers!

@mnieber
Copy link

mnieber commented Jun 20, 2023

@damien Are you using the mdx-components.tsx file and setting mdxRs: true in the config?

@mizlan
Copy link

mizlan commented Jun 27, 2023

@damien Are you using the mdx-components.tsx file and setting mdxRs: true in the config?

I did this but am still experiencing the error. I don't know how to debug what is causing this, in part because I don't understand how mdx-components.tsx is supposed to fix this.

@mnieber
Copy link

mnieber commented Jun 27, 2023

@mizlan Just to be sure, I followed these instructions: https://nextjs.org/docs/app/building-your-application/configuring/mdx (there is a possible gotcha of following the instructions for pages instead of app).

@mizlan
Copy link

mizlan commented Jun 27, 2023

Hmm, yeah I followed that. Also to note, I am trying to use it via a dynamic import, like as here (except his works and mine doesn't, for some reason...)

https://github.com/rafaelalmeidatk/rafaelalmeidatk.com/blob/9be13f0f199221344b9b78e24ec3c7b933de0f4a/src/lib/posts.ts#L25

@kossidts
Copy link

@mizlan I am not sure if this is the solution but I think you need to configure pageExtensions to include md and mdx
as shown in https://nextjs.org/docs/pages/building-your-application/configuring/mdx

// next.config.js
...
const nextConfig = {
    pageExtensions: ['ts', 'tsx', 'js', 'jsx', 'md', 'mdx'],
    ...
}
...

@mizlan
Copy link

mizlan commented Jun 28, 2023

Ah I resolved it, I did something dumb. (I had the "if you're gonna use MDXProvider" part uncommented without actually using that)

Thanks for your time and help!

@levino
Copy link

levino commented Sep 22, 2023

Hi @MatthewCaseres for your case, if you move mdx-components.tsx to the root of your project it fixes the issue

This is the solution!

@x-tropy
Copy link

x-tropy commented Oct 31, 2023

Yes, in my experience mdx-components.tsx is necessary even if you don't want to customize markdown elements. Just create that file and put it in the root folder with content like this:

import React from "react"
import type { MDXComponents } from "mdx/types"

export function useMDXComponents(components: MDXComponents): MDXComponents {
	return {
		...components
	}
}

@ibnumusyaffa
Copy link

ibnumusyaffa commented Dec 8, 2023

placing mdx-components.tsx in the root of project fix this issue

@cruzluna
Copy link

Ensure mdx-components.tsx is at the root ie src/mdx-components.tsx
image

@useEffects
Copy link

Not working with contentlayer + mdx + app

@elie222
Copy link

elie222 commented Jan 16, 2024

This seems to work:

'use client';

import Content from "./content.mdx";

export default function Page() {
  return <Content />;
}

@elie222
Copy link

elie222 commented Jan 16, 2024

How I moved from ContentLayer to Next MDX. ContentLayer seems to no longer be maintained and has a lot of bugs:
elie222/inbox-zero@cf42b0b (#79)

@debsouryadatta
Copy link

Hi @MatthewCaseres for your case, if you move mdx-components.tsx to the root of your project it fixes the issue

Thanks! It helped.

@mastoj
Copy link
Contributor

mastoj commented May 21, 2024

Anyone that has a good explanation to why I have to add "use client" to my page for it to render?

This is what my page.tsx looks like:

"use client";

import { Slide } from "../_slides/config";

type Props = {
  params: {
    id: string;
  };
};

const page = ({ params }: Props) => {
  const slideId = parseInt(params.id, 10);
  return (
    <div>
      <Slide slideId={slideId} />
    </div>
  );
};

export default page;

As I see it that should completely valid without "use client".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: app App directory (appDir: true) bug Issue was opened via the bug report template. Markdown (MDX) Related to Markdown with Next.js.
Projects
None yet
Development

No branches or pull requests