Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font handling in CNA templates #48364

Merged
merged 1 commit into from Apr 14, 2023
Merged

Update font handling in CNA templates #48364

merged 1 commit into from Apr 14, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 13, 2023

We don't need to apply the font className to individual usage and can just apply it to the the top element for easier usage.

x-ref: slack thread

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team labels Apr 13, 2023
@ijjk ijjk marked this pull request as ready for review April 14, 2023 00:23
@ijjk ijjk requested a review from a team as a code owner April 14, 2023 00:23
@ijjk ijjk merged commit 9c5d044 into vercel:canary Apr 14, 2023
90 of 92 checks passed
@ijjk ijjk deleted the update/font-cna-templates branch April 14, 2023 00:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @huozhi