[NEXT-1094] openGraph parent Metadata merging

[bfourgeaud]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Pro
    Binaries:
      Node: 18.12.1
      npm: N/A
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.4.1
      eslint-config-next: 13.4.1
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

Metadata (metadata, generateMetadata, next/head, head.js)

Link to the code that reproduces this issue

https://github.com/bfourgeaud/metadata-merge-repro

To Reproduce

1. Clone, Install & start reproduction project
2. Go to http://localhost:3000
3. The Metadata Infos are OK, no error
4. Go to /child page (link on home page)
5. The error is there

Describe the Bug

Merging of openGraph ResolvedMetadata object into Metadata is throwing an error. Mainly because of images parameter which is not retrieved correctly from parent it seems.
Also url parameter cannot be spread to Metadata and has to be redefined.

export async function generateMetadata(props, parent?: ResolvingMetadata):Promise<Metadata> {
  const parentOpenGraph = (await parent)?.openGraph

  return {
    title: "Child",
    openGraph: {
      ...parentOpenGraph,
      title: "Child",
      url: ""
    }
  }
}

Expected Behavior

It should be possible to merge the parent Metadata (ResolvedMetadata) into the current Metadata. Both objects should be of compatible types.

Which browser are you using? (if relevant)

chrome

How are you deploying your application? (if relevant)

VSCode, Vercel

_NEXT-1094

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.