Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Player.tsx to improve code readability and styling. #50275

Merged
merged 3 commits into from Jun 14, 2023

Conversation

Bowens20832
Copy link
Contributor

Updated the demo player component to have more consistent styling and format.

I thought this could be some nice spring cleaning for the community 馃Ч

Updated the demo player component to have more consistent styling and format.
@Bowens20832 Bowens20832 requested review from a team, leerob and steven-tey as code owners May 24, 2023 13:02
@ijjk ijjk added the examples Issue/PR related to examples label May 24, 2023
@Bowens20832 Bowens20832 changed the title Update Player.tsx Update Player.tsx to improve code readability and styling. May 24, 2023
@Bowens20832
Copy link
Contributor Author

@leerob is using this video.js example the most effective way for a developer to display YouTube videos on their Next.js web app?

Or is there another library or package that you could recommend?

@ijjk ijjk merged commit 862f556 into vercel:canary Jun 14, 2023
31 checks passed
@ijjk
Copy link
Member

ijjk commented Jun 14, 2023

This example is just one strategy, the most effective way will depend on your use case, potentially a simple embed can even work for your use case.

@Bowens20832
Copy link
Contributor Author

This example is just one strategy, the most effective way will depend on your use case, potentially a simple embed can even work for your use case.

Awesome!!

I actually have a simple embed code here: https://github.com/elegantframework/elegant-cli/blob/c9397aa88453fdd61cea3ba7523f41ce12f5488a/source/elegant/src/components/core/Videos/VideoPlayer.tsx

@ijjk Where would a good place be to submit an embed example at?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants