Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update typo in instrumentation page #52311

Merged
merged 4 commits into from Jul 6, 2023
Merged

Conversation

vincenthongzy
Copy link
Contributor

@vincenthongzy vincenthongzy commented Jul 6, 2023

There's a small typo: [pagesExtension] -> [pageExtensions].

Got confused why my instrumentation hook was not called. When I searched my source code for pagesExtension there was no occurrence so I thought I did not use it; soon after I realized the field in the docs has a typo .

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Do you mind updating /docs/02-app/01-building-your-application/05-optimizing/08-open-telemetry.mdx too? 🙏

@vincenthongzy
Copy link
Contributor Author

@delbaoliveira thanks for the catch, updated  👍

@kodiakhq kodiakhq bot merged commit a17f07a into vercel:canary Jul 6, 2023
39 checks passed
@github-actions github-actions bot added the locked label Aug 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants