Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: export force-dynamic from all dynamic routes #52916

Merged

Conversation

dijonmusters
Copy link
Contributor

@dijonmusters dijonmusters commented Jul 20, 2023

What?

Stop with-supabase template from throwing errors on build

Why?

Dynamic Routes now fail the build, rather than console.logging an error

How?

Export the following from any routes that use the cookies function

export const dynamic = "force-dynamic";

Install encoding as a dev dependency until this is fixed downstream

@dijonmusters dijonmusters requested review from a team as code owners July 20, 2023 00:14
@ijjk ijjk added the examples Issue/PR related to examples label Jul 20, 2023
@ijjk
Copy link
Member

ijjk commented Jul 20, 2023

Allow CI Workflow Run

  • approve CI run for commit: 269c5c3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jul 20, 2023

Allow CI Workflow Run

  • approve CI run for commit: e4e997e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ajayvignesh01
Copy link

Thank you for the quick fix!

I think there is also a similar issue with the following template as well:
https://vercel.com/new/templates/next.js/subscription-starter

@kodiakhq kodiakhq bot merged commit 2b49741 into vercel:canary Jul 20, 2023
45 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants