New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Clarify the 'Existing Projects' section of the TypeScript docs: #52944
Conversation
ShaunFerris
commented
Jul 20, 2023
> Add a sentence to the instructions for using typescript in an existing project instructing the user to copy the `paths` compiler option from the existing jsconfig file to the new tsconfig file. > Not doing so causes absolute imports from project directories to break, and gives "Module Not Found" messages that the docs do not have a case for solving"
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
docs/02-app/01-building-your-application/06-configuring/01-typescript.mdx
Outdated
Show resolved
Hide resolved
…escript.mdx Co-authored-by: Steven <steven@ceriously.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint error
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If any maintainer could offer advice on why these checks might be failing, particularly the Validate Doc Links check, I would appreciate it. I apologize if I'm missing something obvious, Cheers! |
GitHub is having an outage https://www.githubstatus.com/incidents/6503rcn8s34s |
The "Validate Docs" was broken in a previous PR. I think the check is actually wrong because the link looks correct. cc @delbaoliveira |
Thanks for pointing that out!c It would be great if you could submit another PR to improve that guide now that you have gone through the process and know what's missing. Thanks! |
Cool I was thinking that I would do that, but just to clarify while I have you here, do you think the line "To contribute, you can edit the files directly on GitHub or clone the repo and edit the files locally." should be changed to remove the option of editing directly on github, as you cant run the linter from githubs editor? (Unless I am missing something). Cheers for the feedback, I am keen to continue contributing! |
Maybe that's the real problem. I bet there is a way to automatically run lint in an action and commit the result. We get 70 PRs a week so anything we can do to reduce friction would benefit everyone 👍 |
That would be the best solve imo. I did edit locally but did not bother setting up the dev env initially as I was just editing mdx, then when I went back to lint this morning I had to spend a fair bit of time to get everything working and roll back my node to skirt around this: pnpm/pnpm#6424 issue in pnpm. Auto linting on docs edits from githubs editor would be a much lower barrier to participation. |