Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eslint config #53637

Merged
merged 4 commits into from Aug 7, 2023
Merged

update eslint config #53637

merged 4 commits into from Aug 7, 2023

Conversation

iamarpitpatidar
Copy link
Contributor

Fixing a bug

  • I checked the eslint config and found that override property is not supposed to be inside another override property.
  • I couldn't checked the entire file as it was a big config file, but I guess it was supposed to be a part of global overrides array of eslint.

@iamarpitpatidar iamarpitpatidar requested review from leerob and a team as code owners August 6, 2023 17:35
balazsorban44
balazsorban44 requested changes Aug 7, 2023
View reviewed changes
.eslintrc.json Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 78b0498 into vercel:canary Aug 7, 2023
51 checks passed
X-oss-byte added a commit to X-oss-byte/next.js that referenced this pull request Aug 20, 2023
@X-oss-byte
Revert "update eslint config (vercel#53637)"
c38542b 
This reverts commit 78b0498.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@leerob leerob Awaiting requested review from leerob leerob is a code owner

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamarpitpatidar @balazsorban44