Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): note cache-control header for preview/draft mode #53825

Merged
merged 3 commits into from Aug 10, 2023
Merged

chore(docs): note cache-control header for preview/draft mode #53825

merged 3 commits into from Aug 10, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 9, 2023 •
edited

You can technically get similar ISR behavior setting the Cache-Control in getServerSideProps(), but this won't be automatically bypassed when enabling Preview Mode or Draft Mode so this PR adds that to the documentation.

x-ref: slack discussion

@styfle styfle requested review from a team as code owners August 9, 2023 21:59
styfle and others added 2 commits August 10, 2023 09:42
@styfle @delbaoliveira
Apply suggestions from code review
0a8680c 
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@styfle
Merge branch 'canary' into fix-docs-getserversideprops-draft-mode
225a788
@kodiakhq kodiakhq bot merged commit 2cf5d3a into canary Aug 10, 2023
52 checks passed
@kodiakhq kodiakhq bot deleted the fix-docs-getserversideprops-draft-mode branch August 10, 2023 14:05
@drichfield
Copy link

You can technically get similar ISR behavior setting the Cache-Control in getServerSideProps(), but this won't be automatically bypassed when enabling Preview Mode or Draft Mode so this PR adds that to the documentation.

This is helpful context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny is a code owner automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

@delbaoliveira delbaoliveira Awaiting requested review from delbaoliveira

@ijjk ijjk Awaiting requested review from ijjk

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@styfle @drichfield @leerob @ijjk @delbaoliveira