Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme in nextjs testing #54322

Merged
merged 5 commits into from Aug 21, 2023
Merged

update readme in nextjs testing #54322

merged 5 commits into from Aug 21, 2023

Conversation

tonskton
Copy link
Contributor

No description provided.

@tonskton
Update on next.js testing import js-dom causes error on latest release
18e1442 
Running the test with the latest js-dom library will fail because of the changes on the import. `extend-expect` is no longer required when importing the library. Please see the release here - https://github.com/testing-library/jest-dom/releases/tag/v6.0.0
@tonskton
Merge pull request #1 from tonskton/tonskton-patch-1
933ce07 
Update on next.js testing import js-dom causes error on latest release
@tonskton tonskton requested review from a team as code owners August 21, 2023 05:58
manovotny
manovotny previously approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@manovotny manovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonskton appreciate you pointing this out and letting us know. 🙏

@kodiakhq kodiakhq bot merged commit 5d758c7 into vercel:canary Aug 21, 2023
47 checks passed
@github-actions github-actions bot added the locked label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manovotny manovotny manovotny approved these changes

@Nutlope Nutlope Awaiting requested review from Nutlope Nutlope is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonskton @manovotny