Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify data type in Forms and Mutations section #54630

Merged
merged 8 commits into from Aug 30, 2023

Conversation

michaelangeloio
Copy link
Contributor

@michaelangeloio michaelangeloio commented Aug 27, 2023

What?

Clarify the "Forms and Mutations" docs.

Why?

This may be opinionated, but I believe this section of the docs starts out assuming that the user knows how the <form> HTML works. Coming from the client side React world, most developers are used to using state in forms. Clarifying that this data is accessible via the standard web API FormData is essential for both transitioning developers and new developers.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@michaelangeloio michaelangeloio changed the title Update 03-forms-and-mutations.mdx docs: clarify data type in Forms and Mutations section Aug 27, 2023
leerob
leerob previously approved these changes Aug 28, 2023
@ijjk
Copy link
Member

ijjk commented Aug 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: cf1aa58

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@michaelangeloio
Copy link
Contributor Author

@leerob failed due to prettier white space. Should be good now 👍

@michaelangeloio
Copy link
Contributor Author

@leerob needs workflow approval after merging canary

@kodiakhq kodiakhq bot merged commit d02124a into vercel:canary Aug 30, 2023
47 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants