Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 03-linking-and-navigating.mdx #55969

Merged
merged 4 commits into from Sep 25, 2023
Merged

Update 03-linking-and-navigating.mdx #55969

merged 4 commits into from Sep 25, 2023

Conversation

riobits
Copy link
Contributor

@riobits riobits commented Sep 25, 2023

I've removed a duplicated example.

@riobits riobits requested review from a team as code owners September 25, 2023 16:46
orca-security-us[bot]
orca-security-us bot reviewed Sep 25, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

styfle
styfle reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the switcher prop and make the second example .js instead?

See line 23-36 for an example of snippets that define both tsx and js

@riobits
Copy link
Contributor Author

riobits commented Sep 25, 2023

sure

styfle
styfle approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 🥇

@styfle styfle added the CI approved Approve running CI for fork label Sep 25, 2023
@kodiakhq kodiakhq bot merged commit 1d86a09 into vercel:canary Sep 25, 2023
58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

@styfle styfle styfle approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit is a code owner automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riobits @styfle @ijjk