Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention missing optimized by default packages in optimizePackageImports #60058

Merged
merged 7 commits into from
Jan 21, 2024

Conversation

AhmedBaset
Copy link
Contributor

Source:

'lucide-react',
'date-fns',
'lodash-es',
'ramda',
'antd',
'react-bootstrap',
'ahooks',
'@ant-design/icons',
'@headlessui/react',
'@headlessui-float/react',
'@heroicons/react/20/solid',
'@heroicons/react/24/solid',
'@heroicons/react/24/outline',
'@visx/visx',
'@tremor/react',
'rxjs',
'@mui/material',
'@mui/icons-material',
'recharts',
'react-use',
'@material-ui/core',
'@material-ui/icons',
'@tabler/icons-react',
'mui-core',
// We don't support wildcard imports for these configs, e.g. `react-icons/*`
// so we need to add them manually.
// In the future, we should consider automatically detecting packages that
// need to be optimized.
'react-icons/ai',
'react-icons/bi',
'react-icons/bs',
'react-icons/cg',
'react-icons/ci',
'react-icons/di',
'react-icons/fa',
'react-icons/fa6',
'react-icons/fc',
'react-icons/fi',
'react-icons/gi',
'react-icons/go',
'react-icons/gr',
'react-icons/hi',
'react-icons/hi2',
'react-icons/im',
'react-icons/io',
'react-icons/io5',
'react-icons/lia',
'react-icons/lib',
'react-icons/lu',
'react-icons/md',
'react-icons/pi',
'react-icons/ri',
'react-icons/rx',
'react-icons/si',
'react-icons/sl',
'react-icons/tb',
'react-icons/tfi',
'react-icons/ti',
'react-icons/vsc',
'react-icons/wi',

@AhmedBaset AhmedBaset requested review from a team as code owners December 30, 2023 20:58
@AhmedBaset AhmedBaset requested review from leerob and lydiahallie and removed request for a team December 30, 2023 20:58
@ijjk
Copy link
Member

ijjk commented Dec 30, 2023

Allow CI Workflow Run

  • approve CI run for commit: b23a47a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this going either way – there are advantages for linking back to the source code directly. Regardless, given there's some list here now, it makes sense to keep the list as close as possible.

@AhmedBaset
Copy link
Contributor Author

AhmedBaset commented Jan 1, 2024

I can see this going either way – there are advantages for linking back to the source code directly. Regardless, given there's some list here now, it makes sense to keep the list as close as possible.

I thought about linking to the code directly but ran into an issue. If we link to the current code, it will be outdated after a while because it won't be updated, and if we link to the Canary branch, the line numbers will change after editing the file in later commits.

@leerob leerob merged commit e4172ea into vercel:canary Jan 21, 2024
29 checks passed
@github-actions github-actions bot added the locked label Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants