Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update parallel routes docs, add default.js pt 1. #60806

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Docs: Update parallel routes docs, add default.js pt 1. #60806

merged 5 commits into from
Jan 18, 2024

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented Jan 18, 2024 •
edited

  • Improve explanation of parallel routes
  • Add default.js API reference
    • Expand on why default.js is needed

Follow up PR:

  • Review and test parallel route examples
    • Modals
    • Conditional Routes
    • Breadcrumbs?
  • Review parallel routes issues

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited

All broken links are now fixed, thank you!

@delbaoliveira delbaoliveira marked this pull request as ready for review January 18, 2024 09:38
@delbaoliveira delbaoliveira requested review from a team as code owners January 18, 2024 09:38
@delbaoliveira delbaoliveira requested review from ismaelrumzan and leerob and removed request for a team January 18, 2024 09:38
@delbaoliveira delbaoliveira changed the title Docs: Update parallel routes docs, add default.js Docs: Update parallel routes docs, add default.js pt 1. Jan 18, 2024
@leerob leerob merged commit cb42417 into canary Jan 18, 2024
34 checks passed
@leerob leerob deleted the next-docs-hg3g branch January 18, 2024 23:57
@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@delbaoliveira delbaoliveira mentioned this pull request Jan 22, 2024
Merged
6 tasks
leerob pushed a commit that referenced this pull request Jan 26, 2024
@delbaoliveira @ztanner
Docs: Improve and add new parallel routes examples (#60981)
5fd0f38 
Continuing from: #60806

- [x] Update **conditional routes** example to render dashboard pages
based on user's role (rather than checking if the user is logged in)
- [x] Add **tab group** example to allow each slot to be navigated
independently.
  - [x] Expand the **modal** example to show full implementation
    - [x] Opening the modal
    - [x] Closing the modal
- [ ] Add **catch-all** slots example
    
Please merge after the diagrams PR:
vercel/front#28770

---------

Co-authored-by: Zack Tanner <zacktanner@gmail.com>
@github-actions github-actions bot added the locked label Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@manovotny manovotny Awaiting requested review from manovotny

Assignees
No one assigned
Labels
created-by: Next.js DevEx team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delbaoliveira @leerob @ijjk