Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct description of skipMiddlewareUrlNormalize in advanced middleware flags #60841

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Evavic44
Copy link
Contributor

I think there's some form of typographical error in the skipMiddlewareUrlNormalize line under the advanced middleware flags section of the docs.

This is the line from the docs Source link:

skipMiddlewareUrlNormalize allows disabling the URL normalizing Next.js does to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.

Corrected to:

skipMiddlewareUrlNormalize allows disabling URL normalizing in Next.js to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.

…nced middleware flags

I think there's some form of typographical error in the `skipMiddlewareUrlNormalize` line under the advanced middleware flags section of the docs.

This is the line from the docs [Source link](https://nextjs.org/docs/app/building-your-application/routing/middleware#advanced-middleware-flags):

```
skipMiddlewareUrlNormalize allows disabling the URL normalizing Next.js does to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.
```

Corrected to:

```
skipMiddlewareUrlNormalize allows disabling URL normalizing in Next.js to make handling direct visits and client-transitions the same. There are some advanced cases where you need full control using the original URL which this unlocks.
```
@Evavic44 Evavic44 requested review from a team as code owners January 18, 2024 19:24
@Evavic44 Evavic44 requested review from manovotny and leerob and removed request for a team January 18, 2024 19:24
…are.mdx

Co-authored-by: Sam Ko <sam@vercel.com>
@samcx samcx self-requested a review January 19, 2024 06:00
@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: 41e470a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx enabled auto-merge (squash) January 19, 2024 06:04
@samcx samcx merged commit 2de7f95 into vercel:canary Jan 19, 2024
29 checks passed
@Evavic44 Evavic44 deleted the patch-2 branch January 19, 2024 06:10
@github-actions github-actions bot added the locked label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants