Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a link to CSP where it's first referenced in the headers docs #60871

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Adds a link to CSP where it's first referenced in the headers docs #60871

merged 2 commits into from
Jan 19, 2024

Conversation

liamlaverty
Copy link
Contributor

@liamlaverty liamlaverty commented Jan 19, 2024

What?

Adds a link to CSP documentation the first time it's mentioned in the headers page here: https://nextjs.org/docs/app/building-your-application/configuring/content-security-policy

Why?

Convenience for users, as it's unclear at that point in the document that CSP is discussing Content-Security-Policy, and the first reference to its docs are at the end of the page.

How?

Added a link to the CSP doc here https://nextjs.org/docs/app/building-your-application/configuring/content-security-policy

@liamlaverty liamlaverty requested review from a team as code owners January 19, 2024 09:24
@liamlaverty liamlaverty requested review from ismaelrumzan and molebox and removed request for a team January 19, 2024 09:24
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx enabled auto-merge (squash) January 19, 2024 18:29
@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: 929d212

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@vercel vercel deleted a comment from ijjk Jan 19, 2024
@vercel vercel deleted a comment from ijjk Jan 19, 2024
@samcx samcx merged commit adae5f2 into vercel:canary Jan 19, 2024
29 checks passed
@github-actions github-actions bot added the locked label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants