chore(docs): fix docs for static assets (public)
#61225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
timeyoutakeit and
delbaoliveira
and removed request for
a team
Ethan-Arrowood
approved these changes
Jan 26, 2024
leerob
reviewed
Jan 26, 2024
docs/02-app/01-building-your-application/06-optimizing/11-static-assets.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/06-optimizing/11-static-assets.mdx
Outdated
Show resolved
Hide resolved
| return <Image src={`/avatars/${id}.png`} alt={alt} width="64" height="64" /> | ||
| } | ||
|
|
||
| export function AvatarOfMe() { |
There was a problem hiding this comment.
Why have two separate components here?
There was a problem hiding this comment.
I'm demonstrating a dynamic src string here.
The previous example wasn't clear why you would use <Image src="/me.jpg" /> vs import me from './me.jpg'; <Image src={me} /> so the new example makes it clear that it works with dynamic url string. (this was feedback from @Ethan-Arrowood)
Co-authored-by: Lee Robinson <me@leerob.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NEXT-2260