Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(02-jest): fixes failing test in the tutorial #61272

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

kenji-webdev
Copy link
Contributor

What?

This PR fixes the example test provided on Setting up Jest with Next.js: Creating your first test: not passing due to Jest not being compatible with async Server Components.

Why?

Although it's noted at the start of the tutorial that async Server Components aren't currently supported by Jest, the example test failing might confuse the reader.

How?

This PR makes the example test pass by removing async from the <Home> component

@kenji-webdev kenji-webdev requested review from a team as code owners January 28, 2024 00:10
@kenji-webdev kenji-webdev requested review from ismaelrumzan and StephDietz and removed request for a team January 28, 2024 00:10
@ijjk
Copy link
Member

ijjk commented Jan 28, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7b0afc5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) January 29, 2024 01:47
@samcx samcx merged commit 093675f into vercel:canary Jan 29, 2024
29 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants