Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #61434 : Docs: Duplicated code snippets #61446

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Fixed #61434 : Docs: Duplicated code snippets #61446

merged 13 commits into from
Feb 5, 2024

Conversation

Sandeep-Mani
Copy link
Contributor

What?

Issue - Docs: Duplicated code snippets

The code snippet is repeated, second snippet had to be with Link component.

How?

Replaced button with Link component.

Fixes #61434 - Docs: Duplicated code snippets

@Sandeep-Mani Sandeep-Mani requested review from a team as code owners January 31, 2024 11:53
@Sandeep-Mani Sandeep-Mani requested review from ismaelrumzan and StephDietz and removed request for a team January 31, 2024 11:53
@styfle styfle added CI approved Approve running CI for fork and removed CI approved Approve running CI for fork labels Feb 5, 2024
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: e076fff

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: e076fff

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: e076fff

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx
Copy link
Member

samcx commented Feb 5, 2024

@Sandeep-Mani No need to merge the latest changes—every time you do, I have to manually approve the commit so the CI can run.

@samcx samcx added the CI approved Approve running CI for fork label Feb 5, 2024
@samcx samcx merged commit 2d48856 into vercel:canary Feb 5, 2024
29 checks passed
@Sandeep-Mani Sandeep-Mani deleted the fix/doc-duplicate-snippets branch February 5, 2024 20:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Duplicated code snippets
5 participants