Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Dashboard-App Chapter 7 - Mismatch between screenshots and current state of RevenueChart #67225

Open
stevenlybeck opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
Documentation Related to Next.js' official documentation.

Comments

@stevenlybeck
Copy link

What is the update you wish to see?

Screenshots on https://nextjs.org/learn/dashboard-app/fetching-data should be changed to match what actually happens for people who have followed the chapters up to this point.

Is there any context that might help us understand?

The page says Then, uncomment the <RevenueChart/> component, navigate to the component file (/app/ui/dashboard/revenue-chart.tsx) and uncomment the code inside it. Check your localhost, you should be able to see a chart that uses revenue data.

In fact, the code currently included in the project for the RevenueChart component (https://github.com/vercel/next-learn/blame/main/dashboard/starter-example/app/ui/dashboard/revenue-chart.tsx) has commented out the part that renders a graph.

So people who have followed the tutorial up to Chapter 7 will not see the graph displayed as shown in the screenshot at https://nextjs.org/learn/dashboard-app/fetching-data#fetching-data-for-revenuechart

The same seems to be true for the LatestInvoices component - the screenshot in the tutorial at https://nextjs.org/learn/dashboard-app/fetching-data#fetching-data-for-latestinvoices - does not match because in the code at https://github.com/vercel/next-learn/blob/main/dashboard/starter-example/app/ui/dashboard/latest-invoices.tsx - most of the component's function has been commented out.

Does the docs page already exist? Please link to it.

https://nextjs.org/learn/dashboard-app/fetching-data

@stevenlybeck stevenlybeck added the Documentation Related to Next.js' official documentation. label Jun 27, 2024
@delbaoliveira
Copy link
Contributor

delbaoliveira commented Jun 28, 2024

Hey @stevenlybeck, the instruction you mentioned above tells the user to navigate to the RevenueChart component and uncomment the code inside it. Was it not clear that you should also uncomment the code inside the component?

If so, we can update the wording for clarity. Perhaps: vercel/next-learn#774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

No branches or pull requests

2 participants