Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up modules removes necessary files #48

Closed
balajmarius opened this issue Jul 15, 2019 · 3 comments
Closed

Cleaning up modules removes necessary files #48

balajmarius opened this issue Jul 15, 2019 · 3 comments

Comments

@balajmarius
Copy link

Hello,

I'm trying to deploy with now (v.2) a monorepo project which uses svgo, and svgo is using a default config file from node_modules/svgo/.svgo.yml.

♻️ During the build phase, on step [5/5] when now is cleaning modules the .svgo.yml file is removed.

I tried to add a .yarnclean file with !.svgo.yml inside but no success.

Any ideas how can I prevent the cleanup step or fix this?

Error: ENOENT: no such file or directory, open '//../../.svgo.yml'

The svgo issue.

@diogoviannaaraujo
Copy link

Im having a similar issue when using shopify-api-node, some folders get wiped from the module during build.

@TooTallNate
Copy link
Member

This is most likely an issue with node-file-trace, so I will transfer this issue over there.

@styfle
Copy link
Member

styfle commented Jun 11, 2020

I am unable to reproduce the issue with the latest node-file-trace and latest svgo.

npm i -g @zeit/node-file-trace
mkdir example && cd example
yarn add svgo
echo "const svgo = require('svgo')" > index.js
nft print index.js | grep yml
# prints "node_modules/svgo/.svgo.yml"

This prints the expected node_modules/svgo/.svgo.yml.

@styfle styfle closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants