Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom middleware support #63

Closed
vjeux opened this issue Jan 18, 2017 · 2 comments
Closed

Custom middleware support #63

vjeux opened this issue Jan 18, 2017 · 2 comments
Assignees

Comments

@vjeux
Copy link

vjeux commented Jan 18, 2017

Would be nice to create an image that you can easily share on twitter.

Some things can could be there:

  • The name of the project + version in one line
  • A facepile of all the contributors that helped with the release
  • Generated by release so more people know about this

That would be pretty sweet :)

@rauchg
Copy link
Member

rauchg commented Jan 21, 2017

Very cool!

We're adding support for a custom release.js in the workdir, which is going to be "middleware" for the release. Today I also had the use case that some releases I want to automatically upload artifacts, so the signature will probably be

release({ commits: [ author, sha, title ], projectData, version }) -> { title, files, desc, version }

And in release.js you could:

  • Invoke the default release desc generator (i.e.: what happens right now)
    • For people who want to release in other locales (i18n) they can write their own
  • Perform side effects (through plugins), like what you're describing. ie: tweet(releaseData)

@rauchg rauchg changed the title Creating a kickass image that can be shared on twitter Custom middleware support Jan 21, 2017
@leo leo self-assigned this Feb 16, 2017
@leo
Copy link
Contributor

leo commented Feb 16, 2017

#38

@leo leo closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants