Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text wrapping implementation #6

Closed
shuding opened this issue Feb 4, 2022 · 0 comments · Fixed by #16
Closed

Improve text wrapping implementation #6

shuding opened this issue Feb 4, 2022 · 0 comments · Fixed by #16
Labels
enhancement New feature or request
Milestone

Comments

@shuding
Copy link
Member

shuding commented Feb 4, 2022

The current implementation is using flex and making each word a node, which is OK and working well. But a better way is to use a typography algorithm and measure it dynamically like this: https://github.com/protectwise/troika/blob/1b52fc9a9a5a3ae03c27d0d12a0f62c3d73fe599/packages/troika-flex-layout/src/FlexLayoutProcessor.js#L217

@shuding shuding added the enhancement New feature or request label Feb 4, 2022
@styfle styfle added this to the Beta milestone Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants