Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url parameter removed when cleanUrls: true #97

Open
SylRob opened this issue Jul 10, 2019 · 1 comment · May be fixed by #144
Open

url parameter removed when cleanUrls: true #97

SylRob opened this issue Jul 10, 2019 · 1 comment · May be fixed by #144
Labels
bug Something isn't working

Comments

@SylRob
Copy link

SylRob commented Jul 10, 2019

when the config cleanUrls is set to true (by default)
and the requested URL is a file name with an extension
and has some parameter in it ex:

/index_2.html?foo&bar=1

the server rewrite the url to

/index_2

and remove the extension AND the url parameters

those URL on the other hand works as intended :

/index_2?foo&bar=1
/?foo&bar=1

/folderName?foo&bar=1

/folderName/?foo&bar=1

question :
is it as intended ?

If the response is "yes, you should set cleanUrls to false" then the README should be mentioning those cases

but I think the cleanUrls setting should set urls like :

/index.html?foo&bar=1 
to
/?foo&bar=1 

it would be more useful

@warren-bank
Copy link

shameless self-promotion alert:
this feature is fixed in my @warren-bank/serve fork of serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants