Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA message should be deprecated #379

Closed
sulliwane opened this issue May 28, 2018 · 7 comments
Closed

CRA message should be deprecated #379

sulliwane opened this issue May 28, 2018 · 7 comments

Comments

@sulliwane
Copy link

sulliwane commented May 28, 2018

This is what Create React App suggest after running npm run build:

The project was built assuming it is hosted at the server root.
You can control this with the homepage field in your package.json.
For example, add this to build it for GitHub Pages:

  "homepage" : "http://myname.github.io/myapp",

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve
  serve -s build

Find out more about deployment here:

http://bit.ly/2vY88Kr

This is deprecated since V7, as the new api is not compatible at all with previous versions.

I will cross post to CRA github, but I think it's also related to this package somehow. maybe you should consider tagging the V7 @next instead of @latest...

@nickmccurdy
Copy link

v7 is the latest stable release. Everything looks fine from Serve's end, we should update CRA's docs and CLI.

@nickmccurdy
Copy link

@sulliwane
Copy link
Author

Ok, thanks for the feedback

@gaearon
Copy link

gaearon commented May 29, 2018

This is very frustrating on our side.

We didn’t add Serve instructions to CRA ourselves. We took a PR from Zeit team. Of course at the time we assumed we can rely on the arguments not changing.

Now all CRA apps have non-working hardcoded instructions.

@sulliwane
Copy link
Author

My sentiment exactly, as that's what happened to me on a production environment and it took me at least 30 minutes to realize and fix the problem

@gaearon
Copy link

gaearon commented May 29, 2018

I filed #382.

@leo
Copy link
Contributor

leo commented May 29, 2018

@sulliwane This is now solved, as per this comment. Sorry for the time we've cost you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants