Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with directories named with spaces #5

Closed
djalmaaraujo opened this issue Jun 19, 2016 · 10 comments
Closed

Doesn't work with directories named with spaces #5

djalmaaraujo opened this issue Jun 19, 2016 · 10 comments

Comments

@djalmaaraujo
Copy link
Contributor

djalmaaraujo commented Jun 19, 2016

http://localhost:4444/ALL/EXT%20DOCUMENTS

Dir name: "EXT DOCUMENTS"

Results on "not found"

Steps to reproduce:

1 - Create a directory called "my custom folder"
2 - run list --port 4444 ~/path/to/parent/dir/of/my custom folder
3 - go to http://localhost:4444/
4 - Click on "my custom folder"
BOOM!

@djalmaaraujo djalmaaraujo changed the title Doesn't work with directories with space on names Doesn't work with directories named with spaces Jun 19, 2016
@rauchg
Copy link
Member

rauchg commented Jun 19, 2016

@djalmaaraujo PRs welcome! Thanks for the report

@leo leo added bug and removed bug labels Jun 19, 2016
@leo
Copy link
Contributor

leo commented Jun 19, 2016

Should be fixed in 14ab2c6. Please confirm! A quick note though: It looks like the path on step 2 is wrong (the spaces should be escaped like shown below)...

~/path/to/parent/dir/of/my\ custom\ folder/

:trollface:

@djalmaaraujo
Copy link
Contributor Author

djalmaaraujo commented Jun 19, 2016

@leo Looks fixed. yay!

Tested on master.

@djalmaaraujo
Copy link
Contributor Author

@leo I don't know if it's related, but when go to the 3rd level, things get crazy. i am investigating the code, but for example, when I am on:

`````` /ALL/BGP%20DOCUMENTS/```

And try to open

/ALL/BGP%20DOCUMENTS/DESIGN

The url goes like this:

/ALL/ALL/BGP%20DOCUMENTS/DESIGN (it is duplicating the ALL)

@djalmaaraujo
Copy link
Contributor Author

@leo fixed on #6

@leo
Copy link
Contributor

leo commented Jun 19, 2016

@djalmaaraujo Everything is fixed now, correct?

@djalmaaraujo
Copy link
Contributor Author

@leo yup.

One thing is missing that I couldn't find a good solution.. directories with "accents". For example: "Presentación". Maybe you can figure out later.

@rauchg
Copy link
Member

rauchg commented Jun 19, 2016

We should be fine with encodeURIComponent ?

image

@djalmaaraujo
Copy link
Contributor Author

@rauchg I tried and it doesn't work. Should we move to another issue? This one looks fixed. I will open one more.

@djalmaaraujo
Copy link
Contributor Author

#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants