Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad upgrade path from TJ’s serve #59

Closed
yuchi opened this issue Dec 15, 2016 · 10 comments
Closed

Bad upgrade path from TJ’s serve #59

yuchi opened this issue Dec 15, 2016 · 10 comments

Comments

@yuchi
Copy link

yuchi commented Dec 15, 2016

Hallo!

Nice to see serve is having a new function! But I see stuff breaking because I expected it to just be a new version of the package, which is not.

Could you at least give some information if someone is trying to render Jade files and similar that this is not that serve?

@derhuerst
Copy link

To make it clear: You're talking about that serve?

@yuchi
Copy link
Author

yuchi commented Dec 15, 2016

@derhuerst Exactly ^~^

@yuchi
Copy link
Author

yuchi commented Dec 15, 2016

That docs still say it is called serve on npm!

@derhuerst
Copy link

npm info serve@1.4.0 author
# TJ Holowaychuk <tj@vision-media.ca>
npm info serve@2.0.0 author
# leo

serve@1.4.0 – tj/serve
serve@2.0.0 – this repo

@derhuerst
Copy link

This should probably be mentioned in the docs of tj/serve.

@yuchi
Copy link
Author

yuchi commented Dec 15, 2016

In fact I currently solved it by installing 1.x.

@leo
Copy link
Contributor

leo commented Dec 15, 2016

According to the SemVer spec, we acted just right. Consider this change a complete rewrite of the package (which, in turn, is considered a major/breaking SemVer change).

Please use the old version of the package, if you'd like to take advantage of the functionalities that existed before the "rewrite".

😊

@leo leo closed this as completed Dec 15, 2016
@derhuerst
Copy link

@yuchi Would you submit a PR at tj/serve to clarify in the docs that server>=2 is in a different repo?

@yuchi
Copy link
Author

yuchi commented Dec 15, 2016

@leo that's right. Obviously right. But a small note should do the job.

@yuchi
Copy link
Author

yuchi commented Dec 15, 2016

@derhuerst I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants