-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier #135
Comments
I wonder if we can just format by |
We can have "prettier" fixtures but we still need a linter for the library code |
oh wait I thought prettier was only for JSX, awesome! |
prettier + linting rules for mistakes / warnings |
I started experimenting with this. My starting point was to lint using The problem: I noticed This might not be a big problem. But before I continue I wanted to check what the general consent is or rather what the expected developer experience is concerning linting and (auto-fixing) code style. My suggestion is to use 📓 You may experiment with the changes here. After cloning (or c/p Update: I just found prettier-eslint and the corresponding cli—both part of the prettier org—which we might just use instead of vanilla |
I just realized me rambling along last night and maybe not making any sense. 🙉 Anyways I submitted a PR which I believe is a good starting point for further discussion. |
@nikvm cool! Maybe we can just use prettier-eslint + omit semicolons? |
@giuseppeg I continued the discussion in the PR thread. |
Currently we use xo to lint our code.We should replace it with standard.js
Let's just add Prettier. See https://github.com/zeit/now-cli/blob/master/package.json#L39-L52
The text was updated successfully, but these errors were encountered: