Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: _JSXStyle import is not found #724

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 31, 2021

Chnages

Carry on work of #716 , generate import id in program scope

Related

Fixes #695
Fixes #696
Fixes #711

@huozhi huozhi requested a review from giuseppeg as a code owner July 31, 2021 10:34
@huozhi huozhi force-pushed the fix/jsxstyle-imports branch 2 times, most recently from 56a1bbb to 626d2b4 Compare July 31, 2021 10:38
src/_utils.js Outdated Show resolved Hide resolved
@masx200
Copy link

masx200 commented Aug 1, 2021

#711 (comment)

Why does this solve the problem?

@huozhi huozhi force-pushed the fix/jsxstyle-imports branch 2 times, most recently from 0d57f9e to 3a07c1f Compare August 1, 2021 07:03
create imports on program enter
src/_utils.js Outdated Show resolved Hide resolved
@huozhi huozhi marked this pull request as draft August 1, 2021 08:24
src/babel.js Show resolved Hide resolved
src/babel-external.js Outdated Show resolved Hide resolved
src/babel.js Show resolved Hide resolved
src/babel.js Show resolved Hide resolved
@huozhi huozhi marked this pull request as ready for review August 2, 2021 08:23
Copy link
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution and for your immense patience Jiachi!

@huozhi huozhi merged commit 2798620 into vercel:master Aug 2, 2021
@huozhi huozhi deleted the fix/jsxstyle-imports branch August 2, 2021 18:49
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

🎉 This PR is included in version 3.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants