-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspense is not resolved and the requests are looping #46
Comments
I also get the same outcome: https://codesandbox.io/s/lucid-field-kbz20 Not sure if the Also unclear if anything special is required for the |
This is indeed a bug due to the deduplication related code. We're working on a fix. |
Regarding the We just added a message to the Quick Start:
Also in the API section:
|
Should be fixed in |
Thanks @quietshu Still seeing the same issue with https://codesandbox.io/s/swr-playground-ku9mq Took fetch out of the equation and used the unit test itself, but still never resolves: function Section() {
const { data } = useSWR(
"suspense-1",
() => new Promise(res => setTimeout(() => res("SWR"), 100)),
{
suspense: true
}
);
return <div>{data}</div>;
}
function App() {
return (
<div className="App">
<Suspense fallback={<div>Loading</div>}>
<Section />
</Suspense>
</div>
);
} This is w/ |
@erikjung sorry that PR wasn't included in |
With this code, i never get the final component, the placeholder stay forever, looking on chrome developer console, the requests are looping.
I made this code using the readme example, i tried change de fetch function to a random promise to see if i get out of fallback, without no results.
I doing something wrong or this is really something that should not happen ?
The text was updated successfully, but these errors were encountered: