Setting up via create-turbo should have yarn checks #241
Labels
good first issue
Good for newcomers
Comments
|
Agree |
|
I would like to work on it. |
|
I am getting this exact same issue for NPM as well, |
|
In my case this was the error when I ran So i had to update Node.js. |
sokra
pushed a commit
that referenced
this issue
Oct 25, 2022
This implements snapshot testing, which writes all chunks to the filesystem. Hopefully these'll be a little quicker to test than the evaluation tests, which require us to spin up a browser to execute. The snapshots will detect if a file is expected (in the output dir) but it's not output by turbopack, if a file is output but was not expected, or if the contents has changed.
It also supports a `TURBOPACK_SNAPSHOT_UPDATE=1` env, which will pass all tests, update all files to the latest outputs, and delete any files that shouldn't exist.
The test structure follows a `*/*/input` directory structure. Eg,
```
large-feature-group
└── explicit-feature
├── input
│ └── index.js
│ └── any-other-files...
│ └── node_modules/...
└── output
└── snapshot_large_feature_group_explicit_feature_input_index.js
└── snapshot_large_feature_group_explicit_feature_input_node_modules_foo_index.js.js
```
The `*/*/output` is the output chunks we expect turbopack to generate.
A few things are still left todo:
- Diffing of the files isn't supported, which would be very helpful for finding changes.
- I didn't handle static assets, and CSS could be broken.
- It only supports `index.js` as the entry point, but we should support many entrypoints (and different filenames and extensions) via an `options.json`.
- We only perform Browser transformations, but we should support any via an `options.json`.
- I don't know if a nested directory structure is possible for output chunks, so it only supports `output/*` files.
sokra
pushed a commit
that referenced
this issue
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the feature you'd like to request
Scenario:
Uninstall yarn completely from the system, and run
It will fail at the second step where it should install the packages via yarn. Because yarn isn't there.
And it gives an unhelpful error:
Describe the solution you'd like
Instead of giving that error, there can be 3 approaches:
yarnisn't found on their system, so either set up the project usingnpm. Just make it like:Press Y to setup with npm instead, or they can quit and restart withnpm.Command yarn not found. Press 1 to install it, or press 2 to set up with npm instead.yarnautomatically. Just put a message sayingInstalling yarn...Describe alternatives you've considered
The alternative is to understand why
yarn installwould fail, which could be because of many reasons I guess. Then figure out that you don't haveyarninstalled, so install it first, then go back to the Turborepo setup.The text was updated successfully, but these errors were encountered: