Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kitchen sink dev not working #306

Closed
NixBiks opened this issue Dec 15, 2021 · 3 comments
Closed

Kitchen sink dev not working #306

NixBiks opened this issue Dec 15, 2021 · 3 comments
Labels
kind: bug Something isn't working

Comments

@NixBiks
Copy link
Contributor

NixBiks commented Dec 15, 2021

What version of Turborepo are you using?

1.0.12

Describe the Bug

I've noticed a few errors in the examples provided. This one is regarding kitchen sink where yarn dev fails for the api service. I.e. nodemon is not installed in api.

Expected Behavior

I'd expect all examples to run without errors. Maybe we should add some testing on all the examples - not sure how to test all the dev/watch jobs though

To Reproduce

Run yarn dev in kitchen sink
@jaredpalmer jaredpalmer added the kind: bug Something isn't working label Dec 15, 2021
@jaredpalmer
Copy link
Contributor

Ahh yeah. Can you add nodemon to deps in a PR?

@NixBiks
Copy link
Contributor Author

NixBiks commented Dec 15, 2021

Sure - will do tomorrow (DK time here).

Should I add an issue for adding tests on examples as well?

@NixBiks NixBiks mentioned this issue Dec 17, 2021
Merged
@NixBiks
Copy link
Contributor Author

NixBiks commented Dec 17, 2021

Fixed in PR #316

@NixBiks NixBiks closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredpalmer @NixBiks