chore: prefactor process manager #7034
Merged
+163
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
commented
Jan 19, 2024
| pub async fn wait_with_piped_outputs<W: Write>( | ||
| &mut self, | ||
| mut stdout_pipe: W, | ||
| mut stderr_pipe: Option<W>, |
There was a problem hiding this comment.
Independently capturing stderr wasn't an used outside of tests and can't be easily done with processes that are hooked up to a pseudo-terminal (possible, but involves redirecting stderr to a file and streaming that). In preparation we remove this feature.
Comment on lines
+120
to
+124
| .stdin(if open_stdin { | ||
| Stdio::piped() | ||
| } else { | ||
| Stdio::null() | ||
| }); |
There was a problem hiding this comment.
This is a behavior change as we will no longer have our children inherit our stdin
There was a problem hiding this comment.
(but that matches the Go eversion)
gsoltis
approved these changes
Jan 19, 2024
🟢 CI successful 🟢Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR lays some ground work for PTY support by hiding implementation details of building the command from users of the
ProcessManager. The public interface forProcessManagerandChildafter this PR no longer use any part oftokio::process.This PR adds our own
Commandstruct that is intended to be used withProcessManager::spawninstead of the raw command builder type which in the future might beportable_pty::CommandBuilder. This approach offers a few benefits:stdin. This was never intended behavior, but an oversight of us not explicitly callingstdin(Stdio::piped())orstdin(Stdio::null()).Testing Instructions
Existing test suite and 👀
Each commit should be easily reviewable on its own.
Closes TURBO-2070