docs: Add info about packages not having the same command #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-burel
requested review from
jaredpalmer,
gsoltis,
gaspar09 and
nathanhammond
as code owners
|
@eric-burel is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
LeSuisse
reviewed
Apr 9, 2022
Co-authored-by: LeSuisse <thomas@gerbet.me>
jaredpalmer
requested changes
Apr 12, 2022
jaredpalmer
added
the
pr: automerge
jaredpalmer
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This looks like a trivial update but coming from Lerna, it's not obvious what will happen if some packages don't have a build step.
For instance my monorepo mixes NPM packages and full-application starters + docusaurus (https://github.com/VulcanJS/vulcan-npm).
The available scripts might vary accross package, some might not have "test" or even a "build" step.
As far as I can tell,
lerna execwon't be that smart for instance and will try to run the same command for every package, failing if its not available to some, so it's worth being more explicit in the doc.