Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pipeline parsing #1038

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Refactor Pipeline parsing #1038

merged 2 commits into from
Apr 11, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 11, 2022

  • Avoid leaking the struct we parse to from JSON in the struct that we use in the remainder of the code
  • Make the struct we use in the remainder of the code more semantically useful.
    • Parse out environment dependencies
    • Split task and topological dependencies
  • Apply default outputs during parsing, rather than during use
  • Rename Pipeline -> TaskDefinition and PipelineConfig -> Pipeline.

Note that the merge base is #951, which we ought to merge first, and then update this to be against main.

@vercel
Copy link

vercel bot commented Apr 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Deployment Preview Updated
turbo-site Deployed View Apr 11, 2022 at 7:07PM (UTC)

jaredpalmer
jaredpalmer previously approved these changes Apr 11, 2022
@gsoltis gsoltis changed the base branch from gsoltis/hash_inputs to main April 11, 2022 19:01
@gsoltis gsoltis dismissed jaredpalmer’s stale review April 11, 2022 19:01

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants