-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor backends to be less-leaky. #1044
Conversation
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a good direction. Just some suggestions on module organization.
cb5036e
to
0638b0e
Compare
0638b0e
to
9011277
Compare
42f8121
to
a24db40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ignored error thing is the only thing here I would consider a blocker. Otherwise LGTM
b09d5b0
to
ebb2a8a
Compare
At this point the main thing that has changed is naming and organization.
Some functionality was moved out of utilities as it has been inlined into the individual places where it is used.