Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backends to be less-leaky. #1044

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Apr 13, 2022

At this point the main thing that has changed is naming and organization.

Some functionality was moved out of utilities as it has been inlined into the individual places where it is used.

@vercel
Copy link

vercel bot commented Apr 13, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 7:39AM (UTC)

cli/internal/package_manager/api/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a good direction. Just some suggestions on module organization.

cli/internal/package_manager/api/types.go Outdated Show resolved Hide resolved
cli/internal/package_manager/nodejs/berry.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ignored error thing is the only thing here I would consider a blocker. Otherwise LGTM

cli/internal/context/context.go Outdated Show resolved Hide resolved
cli/go.mod Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 3b8d81f into vercel:main Apr 21, 2022
@nathanhammond nathanhammond deleted the leaky-backends branch April 22, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants