Add --preflight for sending preflight requests before artifact uploads and downloads #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supports redirects
|
@chelkyl is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
because default behavior is resend request to redirect url, including the preflight request TODO: only follows one redirect, keep following until error or done
also reduce code repetition
chelkyl
requested review from
jaredpalmer,
gsoltis,
gaspar09 and
nathanhammond
as code owners
jaredpalmer
approved these changes
Apr 15, 2022
jaredpalmer
added
the
pr: automerge
|
@chelkyl can you make a follow up PR to be able to configure this w/an env var (e.g. |
|
@jaredpalmer Done with #1063. Thanks! |
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 16, 2022
Follow-up to #1052 per @jaredpalmer's [request](#1052 (comment)) to reduce CLI args clutter.
dutterbutter
pushed a commit
to dutterbutter/docs-turbo
that referenced
this pull request
Nov 1, 2022
Follow-up to #1052 per @jaredpalmer's [request](vercel/turbo#1052 (comment)) to reduce CLI args clutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing --preflight will tell turbo to send a preflight OPTIONS request before every artifact upload (PUT cache artifact or POST analytics) and download (GET cache artifact).
If the server response has a Location header, the follow-up request will use that URL exactly. This means the encoded
slugandteamIdshould probably also be in redirect URL. The internal client will follow 307 and 308 redirects up to 10 times before giving up. The URL of the last request is used as the target URL to upload to and download from.Closes #956
TODO: