Fix remix example by pinning version #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpalmer
requested review from
gsoltis,
gaspar09 and
nathanhammond
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredpalmer
changed the title
|
I think in the first sentence of your comment you intended to say "Remix 1.4 does not appear to work in Yarn, NPM, or PNPM workspaces at the moment." |
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remix 1.4 does not appear to work in Yarn, NPM, or PNPM workspaces at the moment (see screenshot below). In the interim, this pins Remix to 1.0.6. In another PR, we can upgrade it 1.3.5 (which also works), but I have to head out and don't have time. This change at least will fix our test suite