Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git integration cleanup #1194

Merged
merged 1 commit into from May 5, 2022
Merged

git integration cleanup #1194

merged 1 commit into from May 5, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented May 5, 2022

  • Delete a lot of unused git integration code
  • Don't crash in git integration code, return an error instead (remove log.Fatalf instances)
  • Provide a more helpful error message when the user supplies a non-existent commit

Fixes #1157

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview May 5, 2022 at 6:24PM (UTC)

@gsoltis gsoltis marked this pull request as ready for review May 5, 2022 18:26
@kodiakhq kodiakhq bot merged commit 6bc7b4a into main May 5, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/scm_cleanup branch May 5, 2022 18:54
nathanhammond
nathanhammond reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

+ 52
- 183

And lots of things no longer exported. 🎉

cli/internal/scope/scope.go
@@ -92,9 +92,13 @@ func (o *Opts) getPackageChangeFunc(scm scm.SCM, packageInfos map[interface{}]*f
// that the changes we're interested in are scoped, but we need to handle
// global dependencies changing as well. A future optimization might be to
// scope changed files more deeply if we know there are no global dependencies.
changedFiles := []string{}
var changedFiles []string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me learn that range over a nil slice is totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond left review comments

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--filter=[HEAD^1] works but --filter=[HEAD^N] returns error
3 participants
@gsoltis @nathanhammond @jaredpalmer