Drop -- in pnpm invocation for pnpm 7+ #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gsoltis
changed the title
gsoltis
requested review from
jaredpalmer,
gaspar09,
nathanhammond and
tknickman
as code owners
jaredpalmer
approved these changes
Jun 23, 2022
|
This is the upstream change: pnpm/pnpm#4290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpmhandling of--changed for v7.This is not the ideal way to implement this check, but our current abstraction of backends doesn't really allow for anything stateful (e.g. version). Rather than make a new backend for pre- and post-
pnpm@7, I added a check for the version that runs once perturbo runwhenpnpmis being used.A better implementation might in the future include a stateful version field in the backend and the ability to check semver constraints.