Use GoReleaser for Builds #1455
Conversation
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
nathanhammond
force-pushed
the
go-releaser
branch
from
70ecfce
to
fbc81a8
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A good reference for implementation if we want to publish to homebrew, scoop, chocolatey, etc is Planetscale's CLI: https://github.com/planetscale/cli/blob/main/.goreleaser.yml |
|
Either we do a second script for moving assets into place after build (e.g. fbc81a8#diff-04a30fd90db0e74acd7450aeade4bc2150c086d66cfe0c1048dab6dccddb3ecc) or this feature request sticks: goreleaser/goreleaser#3215 |
nathanhammond
force-pushed
the
go-releaser
branch
5 times, most recently
from
4f72300
to
cbf4e69
Compare
nathanhammond
requested review from
jaredpalmer,
gsoltis,
gaspar09 and
tknickman
as code owners
|
This, with the failing test (!) is actually ready for review and to land. The failing test is because it is installing https://github.com/vercel/turborepo/runs/7440069115?check_suite_focus=true#step:8:79 It will work correctly once:
|
There was a problem hiding this comment.
Looks good, I don't have a great way to test this locally so relying on you for the actual release testing since you have the go releaser 🔑 - but the approach looks sound.
Only callout is moving the version.txt to root. This makes sense if we're versioning all the packages along with turbo itself (which we can) but if we're not 100% on that yet, or we deviate, that could cause confusion.
I could see us wanting to keep versions separate - for example create-turbo has no strict dependency on turbo itself, and we likely won't need to push major changes to the packages (with the exception of turbo-ignore since it shells out to turbo, but even that depends on the scope of the breaking CLI change) when turbo has a new major.
But, keeping everything lockstep as you suggested is definitely the simpler approach.
nathanhammond
force-pushed
the
go-releaser
branch
4 times, most recently
from
33439a4
to
2a455c9
Compare
nathanhammond
force-pushed
the
go-releaser
branch
from
638400a
to
b4924b3
Compare
This is to enable using GoReleaser as a first step toward continuous delivery of build artifacts via CI. This is also the first step toward using CGO across a wider array of platforms.