feat(turbo-ignore): update to support vercel CI #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tknickman
requested review from
jaredpalmer,
gsoltis,
gaspar09 and
nathanhammond
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
tknickman
commented
Jul 25, 2022
packages/turbo-ignore/index.js
Outdated
| @@ -1,16 +1,15 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Converting this whole package to TS will also be a part of my "more tests" work
packages/turbo-ignore/utils.js
Outdated
Comment on lines
52
to
69
| export function getComparison() { | ||
| if (process.env.VERCEL === "1") { | ||
| if (process.env.VERCEL_GIT_PREVIOUS_SHA) { | ||
| // use the commit SHA of the last successful deployment for this project / branch | ||
| console.log("\u226B Found previous deployment for project"); | ||
| return process.env.VERCEL_GIT_PREVIOUS_SHA; | ||
| } else { | ||
| // this is either the first deploy of the project, or the first deploy for the branch | ||
| // either way - build it. | ||
| console.log( | ||
| `\u226B No previous deployments found for this project on "${process.env.VERCEL_GIT_COMMIT_REF}"` | ||
| ); | ||
| console.log(`\u226B Proceeding with build...`); | ||
| process.exit(1); | ||
| } | ||
| } | ||
| return "HEAD^"; | ||
| } |
There was a problem hiding this comment.
This is the main change here
nathanhammond
suggested changes
Jul 25, 2022
jaredpalmer
requested changes
Jul 26, 2022
jaredpalmer
approved these changes
Jul 26, 2022
nathanhammond
previously requested changes
Jul 26, 2022
| } | ||
| } | ||
|
|
||
| export function getTurboRoot(): string | null { |
There was a problem hiding this comment.
Can we make this take cwd as an argument?
There was a problem hiding this comment.
I wouldn't block on this. Also, this script runs from the project folder directory on PaaS's
packages/turbo-ignore/package.json
Outdated
| "tsup": "^5.12.1" | ||
| } | ||
| "execa": "5.1.1", | ||
| "fs-extra": "^10.1.0", |
There was a problem hiding this comment.
I think we're not using fs-extra?
Suggested change
| "fs-extra": "^10.1.0", |
| console.error( | ||
| `\u226B Failed to parse JSON output from \`${command}\`.` | ||
| ); | ||
| console.error(`\u226B Proceeding with build to be safe...`); |
There was a problem hiding this comment.
Suggested change
| console.error(`\u226B Proceeding with build to be safe...`); | |
| console.error(`\u226B Exiting with an error to indicate a build should be performed.`); |
There was a problem hiding this comment.
I think this is impl detail. I prefer the original tbh
| packages.length - 1 | ||
| } dependencies` | ||
| ); | ||
| console.log(`\u226B Proceeding with build...`); |
There was a problem hiding this comment.
Suggested change
| console.log(`\u226B Proceeding with build...`); | |
| console.log(`\u226B Exiting with an error to indicate a build should be performed.`); |
| } catch (e) { | ||
| console.error(`\u226B Failed to parse JSON output from \`${command}\`.`); | ||
| console.error(e); | ||
| console.error(`\u226B Proceeding with build to be safe...`); |
There was a problem hiding this comment.
Suggested change
| console.error(`\u226B Proceeding with build to be safe...`); | |
| console.error(`\u226B Exiting with an error to indicate a build should be performed.`); |
| console.log( | ||
| "\u226B This project and its dependencies are not affected" | ||
| ); | ||
| console.log("\u226B Ignoring the change"); |
There was a problem hiding this comment.
Suggested change
| console.log("\u226B Ignoring the change"); | |
| console.log("\u226B This build can be ignored."); |
There was a problem hiding this comment.
I like the active voice here
|
|
||
| try { | ||
| const parsed = JSON.parse(stdout); | ||
| if (parsed == null) { |
There was a problem hiding this comment.
This looks like a TypeScript bug catch. 👍 JSON.parse(null)
Co-authored-by: Nathan Hammond <nathan.hammond@vercel.com>
Co-authored-by: Nathan Hammond <nathan.hammond@vercel.com>
Co-authored-by: Nathan Hammond <nathan.hammond@vercel.com>
nathanhammond
force-pushed
the
turbo_ignore
branch
from
bd8f678
to
0a8e46a
Compare
nathanhammond
added
the
pr: automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to turbo-ignore to be aware of the
$VERCEL_GIT_PREVIOUS_SHA