Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): auto hash framework env vars #1580

Merged
merged 4 commits into from
Jul 27, 2022
Merged

feat(cli): auto hash framework env vars #1580

merged 4 commits into from
Jul 27, 2022

Conversation

tknickman
Copy link
Member

Automatically include framework env vars in task hashes.

@vercel
Copy link

vercel bot commented Jul 25, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 7:09PM (UTC)

nathanhammond
nathanhammond suggested changes Jul 27, 2022
View reviewed changes
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env_test.go Outdated Show resolved Hide resolved
cli/internal/util/env/env_test.go Outdated Show resolved Hide resolved
cli/internal/util/env/env.go Outdated Show resolved Hide resolved
cli/internal/util/env/env_test.go Outdated Show resolved Hide resolved
cli/internal/util/env/env_test.go Outdated Show resolved Hide resolved
nathanhammond
nathanhammond reviewed Jul 27, 2022
View reviewed changes
cli/internal/util/env.go Outdated Show resolved Hide resolved
cli/internal/util/env.go Outdated Show resolved Hide resolved
cli/internal/util/env.go Outdated Show resolved Hide resolved
cli/internal/util/env.go Outdated Show resolved Hide resolved
@nathanhammond nathanhammond added the pr: fixship A PR which is approved with notes and does not require re-review. label Jul 27, 2022
nathanhammond
nathanhammond approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢, one open question.

cli/internal/env/env.go Show resolved Hide resolved
cli/internal/env/env.go Show resolved Hide resolved
@tknickman tknickman added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: fixship A PR which is approved with notes and does not require re-review. labels Jul 27, 2022
@kodiakhq kodiakhq bot merged commit a0433e2 into main Jul 27, 2022
@kodiakhq kodiakhq bot deleted the auto_hash_env_vars branch July 27, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond approved these changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gsoltis gsoltis Awaiting requested review from gsoltis

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tknickman @nathanhammond