Make the defensive behavior correct. #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhammond
requested review from
jaredpalmer,
gsoltis,
gaspar09,
tknickman,
chris-olszewski and
mehulkar
as code owners
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
tknickman
approved these changes
Aug 8, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nathanhammond
commented
Aug 8, 2022
| @@ -102,7 +102,7 @@ publish: clean prepublish build | |||
| git tag "v$(TURBO_VERSION)" | |||
|
|
|||
| # Include the patch in the log. | |||
| git format-patch HEAD~1 --stdout | |||
| git format-patch HEAD~1 --stdout | cat | |||
There was a problem hiding this comment.
This opens more by default, which let me catch the issue.
| cd $(CLI_DIR) | ||
| @test "" = "`git diff cmd/turbo/version.go`" || (echo "Refusing to publish with unupdated version.go" && false) | ||
| @test "" != "`git diff -- cmd/turbo/version.go`" || (echo "Refusing to publish with unupdated version.go" && false) |
There was a problem hiding this comment.
Flipped a clause, and this guarantees the file listing is unambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defensive behavior caught a build issue, but not where I expected it.