Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue evolving Context towards a data structure that can be sent over the wire #788

Merged
merged 5 commits into from Mar 1, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 1, 2022

  • Args doesn't need to hang off of Context
  • TraceFilePath isn't used, tracing is done via RunState instead.
  • global hash calculations and root package.json calculations can use local variables
  • TaskGraph is unused.

@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/CN6xaYHjP1RQ3i4vc3sZUAAKKMmY
✅ Preview: https://turbo-site-git-gsoltis-globalhash.vercel.sh

@gsoltis gsoltis marked this pull request as ready for review March 1, 2022 00:48
Copy link
Contributor

@gaspar09 gaspar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit c9f7264 into main Mar 1, 2022
@gsoltis gsoltis deleted the gsoltis/global_hash branch March 1, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants