Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on e2e #940

Merged
merged 1 commit into from Mar 24, 2022
Merged

Work on e2e #940

merged 1 commit into from Mar 24, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 24, 2022

e2e changes:

  • Add lint tests. These are helpful because they don't have dependencies, so can illustrate future improvements
  • Specify a dependency on "^build" for test. This required changing some matching to .includes rather than exact line matches, as now potentially-cached build tasks are mixed into the output, and they output in a non-deterministic order. We're still matching the same hits and misses though.
  • Start exercising --dry=json a little for testing purposes.

@vercel
Copy link

vercel bot commented Mar 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/3TLumBDE9j1vUB91gg2VDD1AWWjM
✅ Preview: https://turbo-site-git-gsoltis-e2etestdepends.vercel.sh

@gsoltis gsoltis marked this pull request as ready for review March 24, 2022 22:42
@kodiakhq kodiakhq bot merged commit 95028bc into main Mar 24, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/e2e_test_depends branch March 24, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants