Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export VAR="value" syntax in dotenv files #1017

Closed
schickling opened this issue Dec 2, 2017 · 3 comments
Closed

Allow export VAR="value" syntax in dotenv files #1017

schickling opened this issue Dec 2, 2017 · 3 comments

Comments

@schickling
Copy link

schickling commented Dec 2, 2017

It's a quite common use case to use the export keyword in .env files which enables you to run source .env without the need to additionally install any kind of tooling. Currently the now CLI doesn't pick up env vars prepended by an export statement.

Please support this case as well. 👍

@pranaygp
Copy link
Contributor

pranaygp commented Dec 2, 2017

Seems like the npm dotenv maintainers made the decision not to support export statements within .env files (motdotla/dotenv#118)

It also seems as if the suggested course of action is to use this auxiliary package (https://github.com/AndersDJohnson/dotenv-export) on a regular .env file (without the "export" statements)

@leo
Copy link
Contributor

leo commented Dec 4, 2017

Sounds like a good idea if we can just support it without breaking the usual behaviour.

Though it seems like the package that was suggested (dotenv-export) is just a CLI for modifying existing dotenv files that don't yet have the keyword.

What we need is a package that supports parsing both the usual dotenv files and those with the export keyword inside.

@leo
Copy link
Contributor

leo commented Nov 13, 2018

Thank you so much for the effort you have put into this issue! 😊

However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.

You can read more about our biggest release yet here: https://zeit.co/blog/now-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants