Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the progress bar for uploads consider bytes, not number of files #1209

Closed
rauchg opened this issue Mar 26, 2018 · 3 comments
Closed

Make the progress bar for uploads consider bytes, not number of files #1209

rauchg opened this issue Mar 26, 2018 · 3 comments
Assignees

Comments

@rauchg
Copy link
Member

rauchg commented Mar 26, 2018

This will provide a much nicer experience to the end-user, by seeing progress of larger files

@sreeramjayan
Copy link
Contributor

@rauchg
I may have misunderstood the implementation, but the current implementation of the progress bar does consider the bytes when an upload occurs
https://github.com/zeit/now-cli/blob/10eb83207b9d5e5da157a3624167dbf24f1c758d/src/providers/sh/commands/deploy.js#L711
It increments it with each upload
https://github.com/zeit/now-cli/blob/10eb83207b9d5e5da157a3624167dbf24f1c758d/src/providers/sh/commands/deploy.js#L722

@pranaygp pranaygp self-assigned this Apr 3, 2018
@pranaygp
Copy link
Contributor

pranaygp commented Apr 3, 2018

Seems like this actually can't be done with fetch (JakeChampion/fetch#89)
Related: node-fetch/node-fetch#21

@pranaygp
Copy link
Contributor

pranaygp commented Apr 3, 2018

Also related: https://fetch.spec.whatwg.org/#fetch-api

it is currently lacking when it comes to request progression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants