Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routes-manifest.json discovery doesn't take distDir into account #3765

Closed
Janpot opened this issue Feb 7, 2020 · 1 comment
Closed

routes-manifest.json discovery doesn't take distDir into account #3765

Janpot opened this issue Feb 7, 2020 · 1 comment

Comments

@Janpot
Copy link

Janpot commented Feb 7, 2020

This is when using next@canary. Deploys fail when distDir setting is used in next.config.js.

2020-02-07T10:43:15.600Z  Error: A routes-manifest.json couldn't be found. This could be due to a failure during the build
2020-02-07T10:43:15.600Z      at Object.getRoutesManifest (/zeit/e0f2cd85419bbae1/.build-utils/.builder/node_modules/@now/next/dist/index.js:6057:15)
2020-02-07T10:43:15.600Z      at async Object.module.exports.178.exports.build (/zeit/e0f2cd85419bbae1/.build-utils/.builder/node_modules/@now/next/dist/index.js:3823:28)
2020-02-07T10:43:15.600Z      at async buildStep (/var/task/sandbox-worker.js:20292:20)
2020-02-07T10:43:15.600Z      at async mainSub (/var/task/sandbox-worker.js:20047:9)
2020-02-07T10:43:15.600Z      at async main (/var/task/sandbox-worker.js:19975:5)

Looks like it's not being taken into account here: https://github.com/zeit/now/blob/4dc635e5f2a8cc5ff8de9e1d25ff2693c4e37746/packages/now-next/src/utils.ts#L328-L332

@Janpot
Copy link
Author

Janpot commented Feb 7, 2020

Ok, nevermind, just found https://zeit.co/docs/v2/platform/frequently-asked-questions?query=now.json#missing-public-directory

You might want to add a warning for this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant