Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken "name OR 'them'" logic #34

Merged
merged 2 commits into from Mar 8, 2021
Merged

Fix broken "name OR 'them'" logic #34

merged 2 commits into from Mar 8, 2021

Conversation

erikras
Copy link
Contributor

@erikras erikras commented Mar 7, 2021

The way it was will never show name. In fact, I think we can probably assume that name is truthy when sharePage is, but if not, it should show the name, and fall back to 'them'.

Also, the 'them ' string had an extraneous space.

Thanks for this amazing repo! ❤️

@cla-bot
Copy link

cla-bot bot commented Mar 7, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please follow the instructions at https://github.com/vercel/cla.

@vercel
Copy link

vercel bot commented Mar 7, 2021

@erikras is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please sign the CLA and we can go ahead and merge this 😄

@erikras
Copy link
Contributor Author

erikras commented Mar 8, 2021

Sent signed CLA when I submitted the PR. ⏱️

@matheuss
Copy link
Member

matheuss commented Mar 8, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Mar 8, 2021
@vercel vercel deleted a comment from cla-bot bot Mar 8, 2021
@vercel
Copy link

vercel bot commented Mar 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/conference/8MKHCxhCpwjtLFpj2hbyeigvZjyT
✅ Preview: https://conference-git-fork-erikras-patch-1.vercel.sh

@leerob leerob merged commit 806b771 into vercel:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants